Update wasm build to use bigint #1566
Conversation
godot-cpp does not use the same compilation flags for wasm as godot. This change fixes import errors from mismatched function signatures.
tools/web.py
Outdated
| env.Append(CCFLAGS=["-sWASM_BIGINT"]) | ||
| env.Append(LINKFLAGS=["-sWASM_BIGINT"]) |
There was a problem hiding this comment.
In the main repo I could only find this flag appended to LINKFLAGS:
And only when the emscripten version is greater than 3.1.41, or when proxy_to_pthread is enabled.
There was a problem hiding this comment.
Thanks, I'll update pr to do the same.
There was a problem hiding this comment.
| env.Append(CCFLAGS=["-sWASM_BIGINT"]) | |
| env.Append(LINKFLAGS=["-sWASM_BIGINT"]) | |
| env.Append(LINKFLAGS=["-sWASM_BIGINT"]) |
Since we need to build gdextensions with emscripten => 3.1.62 (better if == 3.1.62) to support gdextensions, we don't need to check the compiler version or proxy_to_pthread (in fact, I think we should remove those conditionals in upstream Godot to, and always require emscripten => 3.1.62).
There was a problem hiding this comment.
@Faless I'll create a PR for this for the main repo.
There was a problem hiding this comment.
Looks like we're still waiting on the CCFLAGS line to be removed. But once that's done, I think this should be OK to merge!
There was a problem hiding this comment.
I've opened #1603 because this can't be delayed much longer, since it breaks all web GDExtensions.
Faless
added
bug
dsnopek
added
cherrypick:4.3
cherrypick:4.2
cherrypick:4.1
and removed
cherrypick:4.1
cherrypick:4.2
labels
godot-cpp does not use the same compilation flags for wasm as godot. This change fixes import errors from mismatched function signatures.
Fixes godotengine/godot#96492
Fixes #1553